Feature/464 permission admin view slow #508
Open
+85
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
requested changes
Jan 2, 2025
There was a problem hiding this comment.
I was thinking of the following to make it possible to fetch the fields via the frontend (such that the form doesn't have to be saved to fetch them):
- make an endpoint on the admin (that requires admin authentication) that performs the request for a specific object_type_id to retrieve the
data_fields(e.g./admin/objecttypes/<id>). That way we don't have to expose the token to the frontend and we only need to pass theidto the frontend - in react, call this new endpoint for the currently selected objecttype and display the result
@annashamray what do you think about this?
| return ( | ||
| <div className="errornote"> | ||
| <p>To be able to select fields, first you must save the instance and then you can edit the fields!</p> | ||
| <p>Click on button <strong>'Save and continue editing'</strong></p> |
There was a problem hiding this comment.
This message is now untranslated, I think this should probably be defined as a translatable string in the backend and then passed to the frontend to display it
Suggested change
| <p>Click on button <strong>'Save and continue editing'</strong></p> | |
| <p>Click on the <strong>'Save and continue editing'</strong> button</p> |
| @@ -61,6 +61,14 @@ const authFields = (object_fields, dataFields, fields, setFields) => { | |||
| }; | |||
|
|
|||
| const versionAuthFields = (objectType, objectFields, dataFieldChoices, fields, setFields) => { | |||
| if (!(objectType in dataFieldChoices)) { | |||
| return ( | |||
| <div className="errornote"> | |||
There was a problem hiding this comment.
I'm not sure about making this display as an error message, maybe a warning or info message is more appropriate? Now at first glance it seems as if you can't save the form due to an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
Changes
From the comments of the ticket to solve the problem of slow page loading, the option was chosen not to load all fields of each
objecttypeunnecessarily, but only the fields for a selectedobjecttypeand only if theuse_fieldsflag is also enabled.The initial option I had thought of was to do this on the FE side so that I could make individual requests for each
objecttypeeach time a new value is selected, but this is more difficult because I would have to pass to the view context more elements such asuuid,service_data,tokenetc.. of theobjecttypeto then form, for a correctly and secure request;So I decided to add a simple check to the admin page view, so that if this control passes, a single request is made to retrieve all the
fields datafrom theobjecttype.This way, when the page is reloaded, the permission has all the data and can directly retrieve the information about the fields choices.