⬆️ [#50] updated dependecies and fixed broken oidc tests #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-maykin
force-pushed
the
feature/50-fix-security-issues
branch
4 times, most recently
from
f1a4b21 to
0e6ef7d
Compare
bart-maykin
force-pushed
the
feature/50-fix-security-issues
branch
from
0e6ef7d to
90686be
Compare
bart-maykin
requested review from
annashamray
and removed request for
stevenbal
annashamray
requested changes
Aug 2, 2024
There was a problem hiding this comment.
I have no experience with OIDC and keycloak, so I can't review this part of the PR
@stevenbal Could you help with it please?
| @@ -23,9 +23,11 @@ def __init__( | |||
| def get_kenmerken(self, obj: models.Model, data: dict = None) -> dict: | |||
| data = data or {} | |||
| return { | |||
| kenmerk: data.get("type") or obj.object.object_type.url | |||
There was a problem hiding this comment.
please in the future add black commits into .git-blame-ignore-revs as Sergei suggested
annashamray
approved these changes
Aug 2, 2024
annashamray
approved these changes
Aug 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 95.18% 95.19% +0.01%
==========================================
Files 150 151 +1
Lines 5105 5228 +123
==========================================
+ Hits 4859 4977 +118
- Misses 246 251 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Changes
updated libraries:
3.6.4.0to4.2.05.6.1to5.6.25.2.7to5.4.02020.12.5to2023.7.224.2.11to4.2.156.3.0to6.5.14.3.1to4.4.023.5to24.22.21.4to2.22.03.14.0to3.15.20.27.0to0.27.26.20.0to6.23.02.10to3.73.1.3to3.1.41.0.0to1.0.10.14.1to0.19.00.5.0to0.6.12.8.1to2.9.0.post02.31.0to2.32.31.39.2to2.12.00.4.2to0.5.06.4to6.4.12.2.1to2.2.2updated oidc tests to work for new library version