Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 update demodata with token model change #398

Merged
merged 2 commits into from
May 3, 2024

Conversation

annashamray
Copy link
Collaborator

@annashamray annashamray commented May 2, 2024

The goal of this PR to fix CI in master branch and make it green again.

Explanation why it is broken:

  • We have quick-start CI workflow which uses Objects API image from docker hub and fixtures inside this image
  • In the PR remove primary key from token #397 the structure of Token model was changed, but the related fixtures were not updated
  • The CI was green in the PR because quick-start action uses docker image from docker hub with old Token model structure
  • After the PR was merged the docker image on docker hub was updated, so now we have a docker image with 'latest' tag where demodata fixture and token model have different structures.
  • So to fix it we need to publish a new docker image with updated fixture but to do so we need green CI
  • Therefore loading fixtures is temporarily disabled until the fixtures are updated in the docker image on doker hub

@annashamray annashamray force-pushed the issue/demodata-update branch from df39a53 to c1d669c Compare May 2, 2024 15:56
@annashamray annashamray force-pushed the issue/demodata-update branch from 3861af4 to 7fc6ef4 Compare May 2, 2024 16:04
@annashamray annashamray requested a review from joeribekker May 2, 2024 16:13
Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI was green in the PR because quick-start action uses docker image from docker hub with old Token model structure

Isn't the proper fix to test against the image that was built in the CI-pipeline instead of the latest Docker image on Dockerhub?

@annashamray
Copy link
Collaborator Author

We use demodata fixture only for quick-start, which uses the image published on docker hub. Do we really need this?

@joeribekker joeribekker merged commit 5fd4dbc into master May 3, 2024
8 checks passed
@joeribekker joeribekker deleted the issue/demodata-update branch May 3, 2024 09:18
@joeribekker
Copy link
Member

We use demodata fixture only for quick-start, which uses the image published on docker hub. Do we really need this?

Ah, you are right. The whole goal of that CI-task is to see if the quickstart steps work, which involves downloading the image. OK, I approved it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants