Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#165] Liveness probes experiment [DONT merge] #166

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Jan 15, 2025

Part of #165

To discuss with @sergei-maertens @alextreme @Tiho0135 :

  • How do we feel about the maykinhelmlib?
  • How do we feel about having the liveness probe script as a configmap like this? Advantage: we don't have to update all the projects, disadvantage: we need to update the ansible deploy

@SilviaAmAm SilviaAmAm marked this pull request as draft January 15, 2025 15:06
@SilviaAmAm SilviaAmAm changed the title [#165] Liveness probes experiment [#165] Liveness probes experiment [DONT merge] Jan 15, 2025
@alextreme
Copy link
Member

Having a shared helmlib makes sense, there is a lot of duplication in the charts so I'm in favour of (step by step) converging the templates, although it may make how the charts work less obvious

I don't have an opinion about the liveness probe script in a configmap, I don't know what the best practices are

@sergei-maertens
Copy link
Member

I'm out of my depth to give proper opinions on this, so I leave it for the devops team to come to a consensus.

The only thing catching my eye is that maykinhelmlib isn't particularly inspiring for a lib name. I think it's quite obvious that it's for helm, so repeating that name looks odd to me. Maybe something like maykin-utils or maykin-django-helpers is a better name?

@Tiho0135
Copy link

I fully support the helm library chart, very good suggestion by Silvia.
Using a ConfigMap for the liveness probe script is a normal way to be done. ConfigMaps can be treated as volumes.
I think the advantage is significant since it is implementing the DRY(do not repeat yourself) principle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants