macosx: Make bookmark method a toggle in library menu controller

Signed-off-by: Claudio Cambra <[email protected]>
mayhemheroes · Jul 13, 2024 · 6909294 · 6909294
1 parent 6c6dac1
commit 6909294
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/modules/gui/macosx/library/VLCLibraryMenuController.m b/modules/gui/macosx/library/VLCLibraryMenuController.m
@@ -81,8 +81,8 @@ - (void)createLibraryMenu
     NSMenuItem *informationItem = [[NSMenuItem alloc] initWithTitle:_NS("Information...") action:@selector(showInformation:) keyEquivalent:@""];
     informationItem.target = self;
 
-    NSMenuItem * const bookmarkItem = [[NSMenuItem alloc] initWithTitle:_NS("Bookmark")
-                                                                 action:@selector(bookmark:)
+    NSMenuItem * const bookmarkItem = [[NSMenuItem alloc] initWithTitle:_NS("Toggle Bookmark")
+                                                                 action:@selector(toggleBookmark:)
                                                           keyEquivalent:@""];
     bookmarkItem.target = self;
 
@@ -260,7 +260,7 @@ - (void)showInformation:(id)sender
     [_informationWindowController toggleWindow:sender];
 }
 
-- (void)bookmark:(id)sender
+- (void)toggleBookmark:(id)sender
 {
     if (self.representedInputItems == nil || 
         self.representedInputItems.count != 1 ||
@@ -269,14 +269,19 @@ - (void)bookmark:(id)sender
     }
 
     VLCInputItem * const inputItem = self.representedInputItems.firstObject;
+    NSString * const inputItemMRL = inputItem.MRL;
     NSUserDefaults * const defaults = NSUserDefaults.standardUserDefaults;
     NSMutableArray<NSString *> * const bookmarkedLocations =
         [defaults stringArrayForKey:VLCLibraryBookmarkedLocationsKey].mutableCopy;
     NSNotificationCenter * const defaultCenter = NSNotificationCenter.defaultCenter;
 
-    [bookmarkedLocations addObject:inputItem.MRL];
+    if ([bookmarkedLocations containsObject:inputItemMRL]) {
+        [bookmarkedLocations removeObject:inputItemMRL];
+    } else {
+        [bookmarkedLocations addObject:inputItemMRL];
+    }
     [defaults setObject:bookmarkedLocations forKey:VLCLibraryBookmarkedLocationsKey];
-    [defaultCenter postNotificationName:VLCLibraryBookmarkedLocationsChanged object:inputItem.MRL];
+    [defaultCenter postNotificationName:VLCLibraryBookmarkedLocationsChanged object:inputItemMRL];
 }
 
 - (void)setRepresentedItems:(NSArray<VLCLibraryRepresentedItem *> *)items