Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE81]uzfs_zvol_worker should not free zio_cmd if zio_cmd is related to rebuild write. #92

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

satbirchhikara
Copy link
Collaborator

@satbirchhikara satbirchhikara commented Aug 10, 2018

This fix is avoid double free of zio cmd. This was happening because rebuild was going on volume and meanwhile we have destroyed volume which change state of volume to Offline and freed cmd. Later on same command was freed by rebuild thread. Now fix is to avoid freeing zio cmd in uzfs_zvol_worker if cmd is meant for rebuild write.

@codecov-io
Copy link

Codecov Report

Merging #92 into zfs-0.7-release will decrease coverage by 1.17%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           zfs-0.7-release      #92      +/-   ##
===================================================
- Coverage            52.05%   50.88%   -1.18%     
===================================================
  Files                  241      241              
  Lines                76806    76808       +2     
===================================================
- Hits                 39985    39080     -905     
- Misses               36821    37728     +907

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be0407...f4172e8. Read the comment docs.

@vishnuitta vishnuitta merged commit 635c465 into mayadata-io:zfs-0.7-release Aug 10, 2018
@satbirchhikara satbirchhikara deleted the DE81 branch August 10, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants