[TA1487] Passing correct size to getnameinfo() #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satbir <[email protected]>
jkryl
suggested changes
Jul 2, 2018
lib/libzrepl/data_conn.c
Outdated
| NI_NUMERICSERV); | ||
| rc = getnameinfo(&in_addr, in_len, hbuf, | ||
| sizeof (NI_MAXHOST), sbuf, sizeof (NI_MAXSERV), | ||
| NI_NUMERICHOST | NI_NUMERICSERV); |
There was a problem hiding this comment.
You need to remove sizeof in front of NI_MAXHOST and NI_MAXSERV and the same for kmem_allocs above. Those are integers and not C types.
There was a problem hiding this comment.
Thanks ! Fixed this issue. Please have a look.
Signed-off-by: satbir <[email protected]>
Codecov Report
@@ Coverage Diff @@
## zfs-0.7-release #77 +/- ##
===================================================
- Coverage 50.47% 45.83% -4.64%
===================================================
Files 239 239
Lines 76096 76091 -5
===================================================
- Hits 38406 34874 -3532
- Misses 37690 41217 +3527Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: satbir [email protected]