Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export HTTPError #343

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Export HTTPError #343

merged 1 commit into from
Nov 6, 2024

Conversation

ryepup
Copy link
Contributor

@ryepup ryepup commented Nov 5, 2024

Lets callers use errors.As to differentiate transient outages from license problems.

fixes #341

@ryepup
Copy link
Contributor Author

ryepup commented Nov 5, 2024

Should I add to the changelog in this PR?

@oschwald
Copy link
Member

oschwald commented Nov 5, 2024

That'd be great. Thanks!

Lets callers use `errors.As` to differentiatetransient outages from license problems.

fixes #341
@ryepup
Copy link
Contributor Author

ryepup commented Nov 6, 2024

Changelog updated, I tried to follow the existing format but happy to accept any suggestions.

client/download.go Show resolved Hide resolved
@oschwald oschwald merged commit 4d54326 into maxmind:main Nov 6, 2024
9 of 10 checks passed
@ryepup ryepup deleted the 341-err branch November 6, 2024 22:40
@ryepup
Copy link
Contributor Author

ryepup commented Nov 6, 2024

thanks! Any idea when this might be released?

@oschwald
Copy link
Member

You may have already noticed, but we did a release earlier this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

enable callers to handle Client.Download errors
2 participants