Retry HTTP2 INTERNAL_ERRORs #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marselester
force-pushed
the
retry-http2-internal-err
branch
from
f405c87 to
cf584e5
Compare
marselester
force-pushed
the
retry-http2-internal-err
branch
from
f0e9c87 to
80f9b55
Compare
NajiObeid
reviewed
Jan 25, 2024
NajiObeid
reviewed
Jan 25, 2024
marselester
force-pushed
the
retry-http2-internal-err
branch
from
856185b to
3abc22f
Compare
marselester
force-pushed
the
retry-http2-internal-err
branch
from
3abc22f to
4a3633d
Compare
marselester
force-pushed
the
retry-http2-internal-err
branch
from
4a3633d to
a850ca9
Compare
NajiObeid
approved these changes
Jan 30, 2024
oschwald
reviewed
Jan 30, 2024
| ## 7.0.0 | ||
|
|
||
| * `HTTPReader` no longer retries on HTTP errors and therefore | ||
| `retryFor` was removed from `NewHTTPReader`. |
There was a problem hiding this comment.
It would be good to have a changelog line for the general change of retrying on more types of errors as well.
There was a problem hiding this comment.
Sorry I missed this comment, updating the changelog #280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.