-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret files not getting parsed #262
Comments
We believe the issue is that your secret file contains whitespace. In the next release, we will start trimming whitespace after reading in the files. As an immediate workaround, you could ensure that the file is written without any whitespace, including newlines, carriage returns, spaces, etc. |
That was one of the first thing I checked. I even confirmed that there were no extra new lines, spaces before and after, etc. There were none. My files contained a single line with the string without any extra white-space. |
Vim and most other editors will insert a newline at the end of the file. I assume this is the issue. You can disable this, but if you already have the file, you could run something like |
@oschwald I've been using vi for over 20 years and never realized that a newline gets added when saving the file. Thank you for making me aware of that. I just tested your suggested as well as used |
Glad to hear it worked! |
6.1.0 * `geoipupdate` now sets the version in the `User-Agent` header to the version in the binary. While there were no issues with the version in the header, this makes sure it will match the binary. The header also now includes build information, such as OS and architecture. * White spaces in secret files `GEOIPUPDATE_ACCOUNT_ID_FILE`, `GEOIPUPDATE_LICENSE_KEY_FILE` are ignored, see #262 issue.
There appears to be a problem with reading the secret files when using the
GEOIPUPDATE_ACCOUNT_ID_FILE
andGEOIPUPDATE_LICENSE_KEY_FILE
environment variables. I do see the files are being created in/run/secrets/
within the container and I confirmed that the information matches what I have on my host; however, the following error appear:When
GEOIPUPDATE_ACCOUNT_ID_FILE
is defined in mydocker-compose.yml
, this error appears:When
GEOIPUPDATE_ACCOUNT_ID
is used instead, butGEOIPUPDATE_LICENSE_KEY_FILE
is defined, this error appears:Also, it doesn't appear that the contents of
GEOIPUPDATE_LICENSE_KEY_FILE
gets validated before attempting to use it when making the requests, which is why the above error appears instead of seeing something like:I've also tried changing the ownership and permissions of both the files and the parent directory, but get the same result.
This is what my
docker-compose.yml
file looks like:I've already tried wrapping the environment variables in quotes, but that didn't seem to make any difference.
The text was updated successfully, but these errors were encountered: