No longer allow ipaddress objects in pure Python implementation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
force-pushed
the
greg/object-input
branch
2 times, most recently
from
5a97c66 to
30a4443
Compare
This makes the pure Python implementation consistent with the C extension. The fact that these worked at all was an implementation detail that changed over time.
oschwald
force-pushed
the
greg/object-input
branch
from
30a4443 to
4f18c33
Compare
oschwald
force-pushed
the
greg/object-input
branch
from
77b31c8 to
9ebe165
Compare
andyjack
reviewed
Nov 3, 2017
HISTORY.rst
Outdated
| * IMPORTANT: Previously, the pure Python reader would allow | ||
| `ipaddress.IPv4Address` and `ipaddress.IPv6Address` objects when calling | ||
| `.get()`. This would fail with the C extension. The fact that these objects | ||
| worked at all was an implementation details and has varied with different |
There was a problem hiding this comment.
Thanks! Fixed in e9e1cc2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the pure Python implementation consistent with the C
extension. The fact that these worked at all was an implementation
detail that changed over time.
This PR also includes a fix for #30.