Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Py_INCREF in module initialization #106

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add missing Py_INCREF in module initialization #106

merged 1 commit into from
Jan 9, 2023

Conversation

rcmcdonald91
Copy link
Contributor

No description provided.

@rcmcdonald91 rcmcdonald91 mentioned this pull request Jan 9, 2023
Open
oschwald
oschwald approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

The AddressSanitizer test failure is unrelated. It recently started failing with no changes to the code and we haven't had time to look into it yet.

@oschwald oschwald merged commit d8accfe into maxmind:main Jan 9, 2023
@rcmcdonald91 rcmcdonald91 deleted the rcm-c-incref branch January 9, 2023 21:17
oschwald added a commit that referenced this pull request May 9, 2023
@oschwald
Add history entry for #106
77d2732
This was referenced May 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcmcdonald91 @oschwald