Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python aarch64/arm64 whl releases #152

Closed
kpark-hrp opened this issue Mar 7, 2024 · 6 comments · Fixed by #158
Closed

Python aarch64/arm64 whl releases #152

kpark-hrp opened this issue Mar 7, 2024 · 6 comments · Fixed by #158

Comments

@kpark-hrp
Copy link
Contributor

With increasing popularity of M1/M2/M3 and ARM based cloud computing, it would be immensely helpful to also get aarch64/arm64 whl releases.

Thanks!
@oschwald
Copy link
Member

oschwald commented Mar 7, 2024

I think we will get this automatically once pypa/cibuildwheel supports it. See pypa/cibuildwheel#1746.

@kpark-hrp
Copy link
Contributor Author

@oschwald It looks like MacOS ARM64 is now supported with this merged PR. pypa/cibuildwheel#1700

And indicated by their README
image

@oschwald
Copy link
Member

In that case, this should happen automatically in the next release.

@oschwald
Copy link
Member

We just released 2.6.0 and it doesn't seem like they were created. Maybe we need to tweak our build matrix a bit.

@kpark-hrp
Copy link
Contributor Author

@oschwald I think you need to add macos-14 to the matrix. macos-14 runs on M1, so it covers MacOS arm64.

MaxMind-DB-Reader-python/.github/workflows/release.yml

Line 19 in cc3a709

os: [macos-latest, ubuntu-latest, windows-latest]

@oschwald
Copy link
Member

oschwald commented Apr 1, 2024

Thanks. It looks like you are right. I had no idea that macos-latest meant macos-12. 🙃

oschwald added a commit that referenced this issue Apr 1, 2024
@oschwald
Build releases on macOS 13 and 14
afc74e8 
Apparently, `macos-latest` means macOS 12. We need to to build on 14
Apple silicon support.

Fixes #152.
@oschwald oschwald mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build releases on macOS 13 and 14 maxmind/MaxMind-DB-Reader-python
2 participants
@oschwald @kpark-hrp