Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor tab link click handler & golfing #2082

Merged
merged 2 commits into from
Nov 23, 2023
Merged

feat: Refactor tab link click handler & golfing #2082

merged 2 commits into from
Nov 23, 2023

Conversation

maxmilton
Copy link
Owner

Fixes #2080

  • Prevent closing the current page when clicking on the active "New Tab" page tab link
  • Golf code to reduce final JS file size
  • Rename some things for better clarity and/or to enable mangling

@maxmilton maxmilton added bug Something isn't working enhancement New feature or request labels Nov 23, 2023
@maxmilton maxmilton self-assigned this Nov 23, 2023
@maxmilton maxmilton merged commit 025134f into next Nov 23, 2023
7 checks passed
@maxmilton maxmilton deleted the feat/refactor-tab-click branch November 23, 2023 22:54
maxmilton added a commit that referenced this pull request Nov 23, 2023
@maxmilton
feat: Refactor tab link click handler & golfing (#2082)
f8b7143
@maxmilton maxmilton mentioned this pull request Nov 23, 2023
Closed
maxmilton added a commit that referenced this pull request Nov 23, 2023
@maxmilton
Merge branch 'master' into next
ae638ee 
* master:
  Publish v0.22.0
  feat: Refactor tab link click handler & golfing (#2082)
  chore: Tweak lint rule for byte savings
  chore: Update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxmilton maxmilton

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxmilton