simplifyClaims: remove empty claims arrays

maxlath · Sep 22, 2022 · e45a7e9 · e45a7e9
1 parent c957953
commit e45a7e9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/helpers/simplify_claims.js b/lib/helpers/simplify_claims.js
@@ -12,7 +12,10 @@ const simplifyClaims = (claims, ...options) => {
     if (propertyPrefix) {
       id = propertyPrefix + ':' + id
     }
-    simpleClaims[id] = simplifyPropertyClaims(propClaims, ...options)
+    const simplifiedPropertyClaims = simplifyPropertyClaims(propClaims, ...options)
+    if (simplifiedPropertyClaims.length > 0) {
+      simpleClaims[id] = simplifiedPropertyClaims
+    }
   }
   return simpleClaims
 }

diff --git a/test/simplify_claims.js b/test/simplify_claims.js
@@ -164,6 +164,13 @@ describe('simplifyPropertyClaims', () => {
       simplified.should.deepEqual([ 'Q2044250' ])
     })
 
+    it('should not return empty claims arrays', () => {
+      const deprecatedClaim = Q4115189.claims.P135[0]
+      const claims = { P135: [ deprecatedClaim ] }
+      const simplified = simplifyClaims(claims)
+      should(simplified.P135).not.be.ok()
+    })
+
     it('should return non-truthy statements if requested', () => {
       const options = { keepNonTruthy: true }
       const simplified = simplifyPropertyClaims(Q4115189.claims.P135, options)