-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose Multiplatform #89
Conversation
Amazing work so far! Thanks so much for pushing this topic! |
@DatL4g I get this error when building for iOS:
|
@maicol07 what is your building step exactly? However let's put this in backlog as long as compose |
I'm building my iOS app that uses the library. I'm currently using the latest compose 1.6.10-rc01 and kotlin 2.0.0-rc2 |
@DatL4g can you build and push a new version with the latest compose that seems to fix the error I get? Related issue: JetBrains/compose-multiplatform#4809 |
@maicol07 I published a new release. Keep in mind that Snapshot releases are time based so it's still |
The issue has been fixed, although I had to add these lines to my gradle.properties: kotlin.native.cacheKind=none
compose.kotlin.native.manageCacheKind=false Since K2 and compose 1.6.10 are stable now, you should upgrade them in the lib. |
@maxkeppeler, |
I started reviewing, but since the PR is so large and my time is so limited, it will take a couple of weekends. Feel free to review it additionally. It's great to see this PR. Sorry that I'm not able to act quickly. |
@DatL4g it seems iOS is crashing with the new Compose version: Release 1.7.0-rc01 · JetBrains/compose-multiplatform (github.com) Can you fix it and publish a new snapshot? Probably only rebuilding it with the updated dependencies will work Thanks |
@maicol07 Updated the snapshot. BTW you can just create a small PR next time if you want, then I just have to trigger the release |
Great! Thanks |
Looks overall good. It's way too much to review, even if I have another year. Will do some view/dialog changes beginning next year - especially date-time is not acceptable as it is right now. Huge thanks to you for this amazing contribution. |
This is a (ongoing) refactoring to support Compose Multiplatform.
Will close #66 and #1
Done modules:
Feel free to migrate any module yourself and create a PR.
Snapshot
Repository:
maven("https://s01.oss.sonatype.org/content/repositories/snapshots")
Group:
dev.datlag.sheets-compose-dialogs
Version:
2.0.0-SNAPSHOT
Testers are welcome