[FIRST-19] Test Case(s) for Invoices #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimierzm-iRonin
force-pushed
the
FIRST-20
branch
4 times, most recently
from
bf2f78f to
75f5fb3
Compare
maciej-nedza
requested review from
michalpierog,
patryk-grudzien-keen and
maciej-nedza
test/invoice_test.go
Outdated
| }, | ||
| }, | ||
| assert: func(t *testing.T, resp models.ApiResponse[models.InvoiceResponse], invoice models.CreateInvoice, err error) { | ||
| s.Equal(err.Error(), errors.NewNestedErrorResponse(422, "Unprocessable Entity (WebDAV)").Error()) |
There was a problem hiding this comment.
Is it possible to get any information from NestedErrorResponse?
type NestedErrorResponse struct {
apiError.ApiError
Errors map[string]interface{} `json:"errors,omitempty"`
}
5eb3788 to
fdd64d3
Compare
kazimierzm-iRonin
force-pushed
the
FIRST-20
branch
4 times, most recently
from
155ff94 to
e0cc84f
Compare
kazimierzm-iRonin
force-pushed
the
FIRST-20
branch
from
e0cc84f to
50cdc99
Compare
| ) | ||
|
|
||
| s.NoError(err) | ||
| s.Equal(http.StatusOK, events.Response.StatusCode) |
There was a problem hiding this comment.
Can we add one small assertion that the response list is not empty? Just to check sdk deserializes it
test/invoice_test.go
Outdated
| }, | ||
| }, | ||
| assert: func(t *testing.T, resp models.ApiResponse[models.InvoiceResponse], invoice models.CreateInvoice, err error) { | ||
| // s.Equal(err.Error(), errors.NewNestedErrorResponse(422, "Unprocessable Entity (WebDAV)").Error()) // not able to reat nested error messages here |
There was a problem hiding this comment.
Now it's going to be ErrorArrayMapResponseException
kazimierzm-iRonin
force-pushed
the
FIRST-20
branch
2 times, most recently
from
0534649 to
8b53602
Compare
kazimierzm-iRonin
force-pushed
the
FIRST-20
branch
from
8b53602 to
f627e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.