Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isElectron from ElectronService isn't a boolean #429

Closed
WanielDeiss opened this issue Jan 10, 2020 · 2 comments
Closed

isElectron from ElectronService isn't a boolean #429

WanielDeiss opened this issue Jan 10, 2020 · 2 comments
Labels

Comments

@WanielDeiss
Copy link
Contributor

i always get in electron from isElectron the String "renderer" (from window.process.type) and in web the type undefined.

is think this
return window && window.process && window.process.type;
should be this:
return !!(window && window.process && window.process.type);

pr is incomming, maybe i can write a test for this.

@stale
Copy link

stale bot commented Jan 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 25, 2020
maximegris added a commit that referenced this issue Jan 29, 2020
@WanielDeiss
Copy link
Contributor Author

thanks for the merge, i'll close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant