-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility Go release 1.22 toolchain go1.23.1 #312
Comments
It looks like this PR introduced code that will only work when using In the interim, please use |
dnwe
added a commit
to dnwe/counterfeiter
that referenced
this issue
Jan 17, 2025
- relax go directive to 1.22.0 to match the N-1 and N support statement and permit run/build with go1.22.0 and newer - update the test fixtures go.mod similarly to make them representative - use the toolchain directive to _recommend_ the latest 1.23.x (Go treats this as advisory) - fix the CI build so that oldstable and stable are actually being tested by telling setup-go to ignore the toolchain directive Fixes maxbrunsfeld#312 Signed-off-by: Dominic Evans <[email protected]>
dnwe
added a commit
to dnwe/counterfeiter
that referenced
this issue
Jan 17, 2025
- relax go directive to 1.22.0 to match the N-1 and N support statement and permit run/build with go1.22.0 and newer - update the test fixtures go.mod similarly to make them representative - use the toolchain directive to _recommend_ the latest 1.23.x (Go treats this as advisory) - fix the CI build so that oldstable and stable are actually being tested by telling setup-go to ignore the toolchain directive - use go build tags to add a stub for types.Alias on go1.22 and (somewhat ironically!) use a simple type Alias to the builtin on go1.23 and newer Fixes maxbrunsfeld#312 Signed-off-by: Dominic Evans <[email protected]>
@joefitzgerald mind reviewing #315? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using this sentence in the go.mod file:
toolchain go1.23.1
That change was introduced in this commit: 7cd04d1
The project is set up to be built and tested with Go 1.23.1. It is recommended to use this version to ensure compatibility and avoid potential issues.
As the documentation says:
The Major Go release 1.22 must be supported because the 1.24 is still a release candidate.
Steps to reproduce it:
The text was updated successfully, but these errors were encountered: