Add type definitions in prep for pydata#6086

pydata#6086

setup.cfg

@@ -198,6 +198,8 @@ ignore_missing_imports = True
 ignore_missing_imports = True
 [mypy-h5py.*]
 ignore_missing_imports = True
+[mypy-importlib_metadata.*]
+ignore_missing_imports = True
 [mypy-iris.*]
 ignore_missing_imports = True
 [mypy-matplotlib.*]

xarray/core/dataset.py

@@ -1068,14 +1068,14 @@ def persist(self, **kwargs) -> "Dataset":
     @classmethod
     def _construct_direct(
         cls,
-        variables,
-        coord_names,
-        dims=None,
-        attrs=None,
-        indexes=None,
-        encoding=None,
-        close=None,
-    ):
+        variables: Mapping[Hashable, Variable],
+        coord_names: Set[Hashable],
+        dims: Mapping[Hashable, int] = None,
+        attrs: Mapping = None,
+        indexes: Mapping[Hashable, Index] = None,
+        encoding: Mapping = None,
+        close: Callable[[], None] = None,
+    ) -> "Dataset":
         """Shortcut around __init__ for internal use when we want to skip
         costly validation
         """
@@ -2359,7 +2359,7 @@ def isel(
         indexers = drop_dims_from_indexers(indexers, self.dims, missing_dims)
 
         variables = {}
-        dims: Dict[Hashable, Tuple[int, ...]] = {}
+        dims: Dict[Hashable, int] = {}
         coord_names = self._coord_names.copy()
         indexes = self._indexes.copy() if self._indexes is not None else None