Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For piping workerstreams to other streams (I'm using a websocket-stream) it is convenient for the
data
event payload to be of typeBuffer
, instead ofUint8Array
. This PR checks whether the event data is a typed array, and if so converts it to a (browserify) buffer using typedarray-to-buffer. browserify-buffers are simply augmented Uint8Arrays, so typedarray-to-buffer is a zero-copy operation.websocket-stream also performs a Buffer conversion, here: max-mapper/websocket-stream@0089ece#diff-168726dbe96b3ce427e7fedce31bb0bcR58 (as of 1.0.0) - so I think it makes sense for workerstream to do so as well (with pre-1.0 versions of websocket-stream, I ran into the same problem being fixed here in workerstream)