-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed compile warnings on Linux #8061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it hard to fix those warnings? We should fix warnings unless we have a good reason. Event then the warning guards should be localized on the part of the code that can't get a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matej: "They come from QT headers and mavlink headers I think"
The build error is unrelated to the code: cc1plus: out of memory allocating 67108864 bytes after a total of 140865536 bytes
@stefandunca There a number of these which come from mavlink headers. Those should be fixed in mavlink to get mavlink headers to compile clean. Can you create an issue against mavlink so this can be fixed? I'm fine with turning those off until mavlink gets fixed.
|
FYI: I'll see if pulling a new eigen will get rid of all the crap from there. |
There are a lot of deprecated-copy warnings coming from QT headers: /home/matej/Qt/5.12.6/gcc_64/include/QtCore/qvariant.h: In constructor ‘QVariant::QVariant(QVariant&&)’: |
9584fd0
to
5d551a2
Compare
323dece
to
04a134d
Compare
Building QGC on Ubuntu 19.10 with gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 produces lots of warnings. Some of these warnings were already disabled in builds for other platforms so I added them also to Linux build.