Switch to new REQUEST_MESSAGE but fall back to deprecated request message commands if required #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
changed the title
JonasVautherin
previously approved these changes
Aug 20, 2024
This is a first step towards consistently using the new REQUEST_MESSAGE commands everywhere while still being able to fall back to the deprecated commands on retries.
julianoes
force-pushed
the
pr-request-old-messages
branch
from
bf73ee8
to
06f485d
Compare
Just to name this consistently with other MAVLink helpers like this.
The home position is now requested until valid, for both PX4 and ArduPilot. Presumably, I had broken this in a previous cleanup.
We no longer support gimbal v1 (MOUNT) commands with the next MAVSDK major release.
This allows to register and unregister mavlink messages in any context, even if the the mavlink message handler lock is already taken.
|
@JonasVautherin do you mind double checking the last commit please, thanks! Better to get that one right... |
|
|
It looks good to me! Though I haven't tested it, I only read the commit (carefully, though). Let me know if you need me to test something. |
|
Thanks @JonasVautherin! It fixes the system_test failure, so that's enough testing for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the logic of requesting messages using the new command as well as the deprecated commands consolidated in the RequestMessage class.
Currently WIP implementing the functionality in REQUEST_MESSAGE. The next step is to use this class consistently everywhere.
Closes #1605, closes #2013.