Consolidate components #2169
Merged
Consolidate components #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-split-mission-transfer
branch
from
7e6fc79
to
4209e2d
Compare
julianoes
force-pushed
the
pr-consolidate-components
branch
from
3de652f
to
1781fa5
Compare
julianoes
force-pushed
the
pr-split-mission-transfer
branch
from
4209e2d
to
8ea5f9f
Compare
julianoes
force-pushed
the
pr-consolidate-components
branch
from
1781fa5
to
c38401f
Compare
julianoes
force-pushed
the
pr-split-mission-transfer
branch
from
8ea5f9f
to
eecaaa2
Compare
julianoes
force-pushed
the
pr-consolidate-components
branch
from
c38401f
to
d1ad6df
Compare
|
@JonasVautherin and @ThomasDebrunner I'm thinking of changing the API to require a default, so from: to: What do you think? And should it be a breaking change or deprecation notice if you use it without constructor? Related to #2125. |
For me it is fine to completely remove the default and make the build fail if no value is passed. It's fine because it will be a major update, and it's very easy to fix ("oh, it now requires an argument"). Also it's good to make it explicit since apparently some people got confused by the fact that MAVSDK may behave as a ground station by default. |
julianoes
force-pushed
the
pr-consolidate-components
branch
from
d1ad6df
to
e767e7a
Compare
This is an attempt to avoid spurious segfaults happening in some of the CI tests for some of the system tests. Presumably they happen on the quick destruction of the objects right after construction. Signed-off-by: Julian Oes <[email protected]>
This should make dealing with the configuration and components a bit clearer. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-consolidate-components
branch
from
e767e7a
to
7e30cfb
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make dealing with the configuration and components a bit clearer.
This is the last step towards v2 🤞.
Closes #2125.