Code

More issues caught by linter#79

Code

Open

qua3k wants to merge 17 commits intomautrix:mainmautrix/go:mainfrom qua3k:lintqua3k/go:lintCopy head branch name to clipboard

+106-100

Commits

Commits on Jun 14, 2022

• Fix S1009 issue discovered by linter

  Show description for 03fafa8
  qua3k

  committed
  03fafa8

• Remove unused upgrades field found by structcheck

  qua3k

  committed
  cda6823

• Remove unused typingLock found by structcheck

  qua3k

  committed
  238fb11

• S1031: remove unnecessary nil check around range

  qua3k

  committed
  9ade3e6

• Remove unnecessary assignments to blank identifier

  qua3k

  committed
  8c54394

• S1012: replace time.Now.Sub with time.Since

  qua3k

  committed
  61550bb

• Remove ineffectual assignment to res

  qua3k

  committed
  b719312

• Outdent else block

  qua3k

  committed
  69a16bd

• Explicitly close response body

  qua3k

  committed
  69d5b93

• Preallocate children slice

  qua3k

  committed
  3ad32bc

• Replace numerous if/else chains with switch

  qua3k

  committed
  f33710b

• Fold else...if into else if

  qua3k

  committed
  24ef857

• Remove unnecessary conversion

  qua3k

  committed
  8f51c2c

• Remove unnecessary slices

  qua3k

  committed
  cdc52cb

• Replace strings.Replace with ReplaceAll

  qua3k

  committed
  9bc60af

• Use %w instead of %v for errors

  Show description for ff2bffa
  qua3k

  committed
  ff2bffa

• Replace archaic error comparison with errors.Is

  Show description for 1bd773d
  qua3k

  committed
  1bd773d