This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Web Push Notification update with new options and images/badge/icons … #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kuzmany is this one still relevant? If so, can you resolve conflicts? |
virgilwashere
suggested changes
Nov 3, 2019
There was a problem hiding this comment.
As per @RCheesley question, if this is still relevant, please update to match the new style guide.
| @@ -10,23 +10,23 @@ For more information see [One Signal documentation](https//documentation.onesign | |||
|
|
|||
| ##### 2. Setup app Website Push Platforms in you app | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Suggested change
|  | |
|  |
There was a problem hiding this comment.
Repeat for other image links.
See new CONTRIBUTING for updates on image links.
| @@ -66,4 +66,17 @@ Don't forget copy these files to root dir of your tracking page: | |||
|
|
|||
| https://yourmauticurl.tld/manifest.json | |||
There was a problem hiding this comment.
Suggested change
| https://yourmauticurl.tld/manifest.json | |
| https://example.com/manifest.json |
| ### Settings | ||
|
|
||
| Mautic 2.14.1 added manage notification images and action buttons. Just read tooltip with every new field on add/edit notification with basic info about upload image format and size. Use preview button and see How It should generate. |
There was a problem hiding this comment.
Suggested change
| Mautic 2.14.1 added manage notification images and action buttons. Just read tooltip with every new field on add/edit notification with basic info about upload image format and size. Use preview button and see How It should generate. | |
| [Mautic 2.14.1][release-2.14.1] added manage notification images and action buttons. Read the tooltip for every new field in add/edit notification for basic information about upload image format and size. | |
| Use the preview button and test generation. | |
| [release-2.14.1]: <https://github.com/mautic/mautic/releases/tag/2.14.1> | |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed path to image path and add docs to PR mautic/mautic#5695