Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mautic in test mode to speed up tests #309

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jul 27, 2023

by using test env, we can use the speed optimised password hashing with md5

before
Screenshot 2023-07-29 at 22 10 00

after
Screenshot 2023-07-29 at 22 10 13

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #309 (ff3b26a) into main (c6c23d5) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head ff3b26a differs from pull request most recent head 2738b68. Consider uploading reports for the commit 2738b68 to get more accurate results

@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
- Coverage     52.59%   52.49%   -0.10%     
  Complexity      390      390              
============================================
  Files            30       30              
  Lines          1042     1042              
============================================
- Hits            548      547       -1     
- Misses          494      495       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mollux mollux force-pushed the test_speed_test_env branch from 55d22e1 to 473eebd Compare July 29, 2023 19:48
@mollux mollux force-pushed the test_speed_test_env branch from 473eebd to 2738b68 Compare July 29, 2023 19:59
@mollux mollux requested review from escopecz and RCheesley July 29, 2023 20:11
@mollux mollux changed the title use mautic in test mode to speed it up use mautic in test mode to speed up tests Jul 29, 2023
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite some improvement in speed! 😱 🚀

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! 👍 🚀

@escopecz escopecz merged commit 84bd02f into main Jul 31, 2023
@escopecz escopecz deleted the test_speed_test_env branch July 31, 2023 09:03
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants