NET Core 2.0 version #38
Conversation
FsSql/AsyncExtensions.fs
Outdated
| Async.FromBeginEnd(abegin, aend, acancel) | ||
| member cmd.AsyncExecReader(?cancellationToken:CancellationToken) : SqlDataReader Async = | ||
| match cancellationToken with | ||
| | Some ct -> cmd.ExecuteReaderAsync(ct) |> Async.AwaitTask |
There was a problem hiding this comment.
This is bugged since async needs to be re-executable (cold) and tasks are hot. See if you can defer the creation of the task into an async workflow or something of the like.
|
Now it could be a long wait; you should consider publishing a package meanwhile, as @mausch isn't very active any more. |
|
@irium Would you consider forking and maintaining at another nuget id, please? |
|
@haf I'm not sure I have time to fully maintain public NuGet package. I could try. What name we'll choose for new NuGet? FsSql.Core maybe? |
|
@irium There's not much traffic to this nuget, so you'd probably not have to spend too much time on it. I'm happy to hear you're considering it. Sure, FsSql.Core could work. |
|
Ok :) Now I'm learning how to configure all this nuget publishing :) |
|
https://github.com/haf/expecto is a good example |
|
@haf Here it is: https://www.nuget.org/packages/FsSql.Core/ I think it makes sense to move further PRs and issues to https://github.com/irium/FsSql |
|
@irium I noticed there is no way to post issues on your fork. Not that I have an issue to submit, but if I did in the future, how would I be able to do that? |
|
@irium needs to go to settings, enable issues. |
|
@irium Thank you! |
I've ported FsSql to .NET Core 2.0.
With some changes: