Attempt to invoke virtual method 'void executeProviderCommand(int, int)' on a null object reference #280

TimurAsayonok · 2018-09-14T14:13:24Z

Your Environment

Plugin version: 0.5.0-alpha.40
Platform: Android
OS version: from Android 5.0
Device manufacturer and model: -
React Native version: 0.52.2
Plugin configuration options: I'm using default configuration options
Link to your project: -

Context

We use our application on production with more than 100+ users per week. About 30% users on android has problem with
Unable to pause activity {com.shopper_app/com.reactnativenavigation.controllers.NavigationActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference.

We use react-native-background-geolocation lib for getting user localization on background and for this task we use getCurrentLocation(success, fail, options) method.

Expected Behavior

We can get localization and application won't be crashed

Actual Behavior

We can't get localizationa and get fatal error on sentry system bug report

Possible Fix

Steps to Reproduce

Context

About 30% android users are getting this error and crush, it's big problem for us

Debug logs

Unable to pause activity {com.shopper_app/com.reactnativenavigation.controllers.NavigationActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference
    at com.marianhello.bgloc.BackgroundGeolocationFacade.switchMode(BackgroundGeolocationFacade.java:413)
    at com.marianhello.bgloc.BackgroundGeolocationFacade.pause(BackgroundGeolocationFacade.java:304)
    at com.marianhello.bgloc.react.BackgroundGeolocationModule.onHostPause(BackgroundGeolocationModule.java:114)
    at com.facebook.react.bridge.ReactContext.onHostPause(ReactContext.java:214)
    at com.facebook.react.ReactInstanceManager.moveToBeforeResumeLifecycleState(ReactInstanceManager.java:700)
    at com.facebook.react.ReactInstanceManager.onHostPause(ReactInstanceManager.java:534)
    at com.reactnativenavigation.react.NavigationReactGateway.onPauseActivity(NavigationReactGateway.java:79)
    at com.reactnativenavigation.controllers.NavigationActivity.onPause(NavigationActivity.java:162)
    at android.app.Activity.performPause(Activity.java:6815)
    at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1323)
    at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3906)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3883)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3857)
    at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3831)
    at android.app.ActivityThread.-wrap16(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1584)
    at android.os.Handler.dispatchMessage(Handler.java:110)
    at android.os.Looper.loop(Looper.java:203)
    at android.app.ActivityThread.main(ActivityThread.java:6361)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1063)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:924)
java.lang.RuntimeException: Unable to pause activity {com.shopper_app/com.reactnativenavigation.controllers.NavigationActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference
    at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3924)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3883)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3857)
    at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3831)
    at android.app.ActivityThread.-wrap16(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1584)
    at android.os.Handler.dispatchMessage(Handler.java:110)
    at android.os.Looper.loop(Looper.java:203)
    at android.app.ActivityThread.main(ActivityThread.java:6361)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1063)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:924)

The text was updated successfully, but these errors were encountered:

equesteo · 2018-09-17T15:43:19Z

I hit the same error yesterday.

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference
    at com.marianhello.bgloc.BackgroundGeolocationFacade.switchMode(BackgroundGeolocationFacade.java:413)
    at com.marianhello.bgloc.BackgroundGeolocationFacade.pause(BackgroundGeolocationFacade.java:304)
    at com.marianhello.bgloc.react.BackgroundGeolocationModule.onHostPause(BackgroundGeolocationModule.java:114)
    at com.facebook.react.bridge.ReactContext.onHostPause(ReactContext.java:212)
    at com.facebook.react.ReactInstanceManager.moveToBeforeResumeLifecycleState(ReactInstanceManager.java:662)
    at com.facebook.react.ReactInstanceManager.onHostPause(ReactInstanceManager.java:486)
    at com.reactnativenavigation.react.NavigationReactGateway.onPauseActivity(NavigationReactGateway.java:79)
    at com.reactnativenavigation.controllers.NavigationActivity.onPause(NavigationActivity.java:162)
    at android.app.Activity.performPause(Activity.java:6824)
    at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1323)
    at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3769)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3746)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3720)
    at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3694)
    at android.app.ActivityThread.-wrap16(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1508)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6186)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

java.lang.RuntimeException: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference
    at com.facebook.react.bridge.ReactContext.handleException(ReactContext.java:311)
    at com.facebook.react.bridge.ReactContext.onHostPause(ReactContext.java:214)
    at com.facebook.react.ReactInstanceManager.moveToBeforeResumeLifecycleState(ReactInstanceManager.java:662)
    at com.facebook.react.ReactInstanceManager.onHostPause(ReactInstanceManager.java:486)
    at com.reactnativenavigation.react.NavigationReactGateway.onPauseActivity(NavigationReactGateway.java:79)
    at com.reactnativenavigation.controllers.NavigationActivity.onPause(NavigationActivity.java:162)
    at android.app.Activity.performPause(Activity.java:6824)
    at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1323)
    at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3769)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3746)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3720)
    at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3694)
    at android.app.ActivityThread.-wrap16(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1508)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6186)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

java.lang.RuntimeException: Unable to pause activity {com.equesteo/com.reactnativenavigation.controllers.NavigationActivity}: java.lang.RuntimeException: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.marianhello.bgloc.LocationService.executeProviderCommand(int, int)' on a null object reference
    at android.app.ActivityThread.performPauseActivityIfNeeded(ActivityThread.java:3780)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3746)
    at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3720)
    at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3694)
    at android.app.ActivityThread.-wrap16(ActivityThread.java)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1508)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6186)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

TimurAsayonok · 2018-09-20T13:31:35Z

@mauron85 Could you help us?

mauron85 · 2018-09-26T12:58:00Z

Is this happening also on latest alpha?

TimurAsayonok · 2018-09-26T17:53:55Z

@mauron85 I will update to latest version on this week and will test on the production. I will write to you later

fhassanpur · 2018-09-26T20:28:03Z

I'm also running into this issue. One of the virtual devices doesn't experience it but the other and my real device does. However, it's strange because the AVD that crashes is running Android 5.0.2, my real device is running 8.1, but the AVD that doesn't crash is running 6.0.

Enviornment:

Plugin version: 0.5.0-alpha.48
Platform: Android
OS version: from Android 8.1, 5.0.2
Device manufacturer and model: - ONEPLUS A5010 (5T) - 8.1.0, PIXEL_API_21(AVD) - 5.0.2
React Native version: 0.55.3
Plugin configuration options: default

mauron85 · 2018-09-26T20:46:21Z

It would be helpful if you can write down steps how to replicate, or at least some preconditions leading to crash (eg. app terminated but running in bg, ...). The more info, the better.

TimurAsayonok · 2018-09-28T09:01:29Z

@mauron85 We have updated and publish new public version of our application. We will try to get more information

fhassanpur · 2018-09-28T19:17:53Z

The application was crashing on startup, I believe as the native components were being loaded by the React Native bridge.

I was able to find a temporary fix, but I'm not sure what kind of effect it will have on the system overall.

In BackgroundGeolocationFacade.java, I found that the checking for null before calling switchMode() in pause() seemed to keep it from crashing.

    public void pause() {
        if (mService != null)
        {
            switchMode(BackgroundGeolocationFacade.BACKGROUND_MODE);
        }
        unbindService();
    }

Technically, this change needs to be in the background-geolocation-android repo. I'm not too familiar with the service lifecycle, but this should be okay right?

mauron85 · 2018-09-29T09:11:12Z

@fhassanpur thanks for good lead. After some investigation I think the crash is caused when service is not yet connected/created and app is moving to background. So that null check is perfect fix and just workaround.

mauron85 · 2018-09-29T09:12:48Z

I'm going to pull this PR which will also fix this.
https://github.com/mauron85/background-geolocation-android/pull/17/files

fixes: mauron85/react-native-background-geolocation#257 mauron85/react-native-background-geolocation#280

@ivosabev

Origin-PR: mauron85/background-geolocation-android#17 Contributed-By: @ivosabev Fixes: #257, #280

mauron85 · 2018-09-29T09:45:07Z

Should be fixed in alpha.42. Closing for now. Please feel free to reopen when necessary.

mauron85 added the waiting for input label Sep 26, 2018

mauron85 pushed a commit to mauron85/background-geolocation-android that referenced this issue Sep 29, 2018

Make sure mService exists when we call start or stop (PR #17)

0ae8e46

fixes: mauron85/react-native-background-geolocation#257 mauron85/react-native-background-geolocation#280

mauron85 added a commit that referenced this issue Sep 29, 2018

Make sure mService exists when we call start or stop

9af522f

Origin-PR: mauron85/background-geolocation-android#17 Contributed-By: @ivosabev Fixes: #257, #280

mauron85 closed this as completed Sep 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to invoke virtual method 'void executeProviderCommand(int, int)' on a null object reference #280

Attempt to invoke virtual method 'void executeProviderCommand(int, int)' on a null object reference #280

TimurAsayonok commented Sep 14, 2018

equesteo commented Sep 17, 2018 •

edited

Loading

TimurAsayonok commented Sep 20, 2018

mauron85 commented Sep 26, 2018

TimurAsayonok commented Sep 26, 2018

fhassanpur commented Sep 26, 2018

mauron85 commented Sep 26, 2018

TimurAsayonok commented Sep 28, 2018

fhassanpur commented Sep 28, 2018 •

edited

Loading

mauron85 commented Sep 29, 2018

mauron85 commented Sep 29, 2018

mauron85 commented Sep 29, 2018

Attempt to invoke virtual method 'void executeProviderCommand(int, int)' on a null object reference #280

Attempt to invoke virtual method 'void executeProviderCommand(int, int)' on a null object reference #280

Comments

TimurAsayonok commented Sep 14, 2018

Your Environment

Context

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Context

Debug logs

equesteo commented Sep 17, 2018 • edited Loading

TimurAsayonok commented Sep 20, 2018

mauron85 commented Sep 26, 2018

TimurAsayonok commented Sep 26, 2018

fhassanpur commented Sep 26, 2018

mauron85 commented Sep 26, 2018

TimurAsayonok commented Sep 28, 2018

fhassanpur commented Sep 28, 2018 • edited Loading

mauron85 commented Sep 29, 2018

mauron85 commented Sep 29, 2018

mauron85 commented Sep 29, 2018

equesteo commented Sep 17, 2018 •

edited

Loading

fhassanpur commented Sep 28, 2018 •

edited

Loading