Disabled notification sound and vibration on oreo #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgindi
changed the title
|
I would prefer making this configurable. |
|
This would involve a much deeper change, as |
|
I think we should start with this, to supply the default expected behavior. I'm not familiar with the library so much that I'd feel comfortable changing it's structure yet. |
|
Ok. Let's see. |
|
Merged. Thank you! |
mauron85
added a commit
to mauron85/react-native-background-geolocation
that referenced
this pull request
Aug 20, 2018
Origin-PR: mauron85/background-geolocation-android#9 Contributed-By: @danielgindi
mauron85
added a commit
to mauron85/cordova-plugin-background-geolocation
that referenced
this pull request
Aug 20, 2018
Android - disable notification sound and vibration on oreo Origin-PR: mauron85/background-geolocation-android#8 mauron85/background-geolocation-ios#3 Contributed-By: @danielgindi Origin-PR: mauron85/background-geolocation-android#9 Contributed-By: @danielgindi
|
Still plays notification sound. Tested on Galaxy S8 Oreo 8.0 and Emulator API 26. |
|
I'm afraid it will not work for applications that are already installed, as notification channels are only created once. Creating them again does not update them. |
|
Yes, reinstall was solved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Oreo you can't count on the notification's defaults, or even settings that you've set explicitly, because the
NotificationChannelis pre-defined with an annoying sound and vibration.This is too alarming to the user, and happens multiple times.
This fixes the behavior on Oreo.
Closes: mauron85/react-native-background-geolocation#260