Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nullpointer exceptions #2

Closed
wants to merge 3 commits into from
Closed

Conversation

chuece
Copy link
Contributor

@chuece chuece commented Mar 27, 2018

This fixes some edge cases that can lead to unexpected app crashes

@mauron85
Copy link
Owner

Merged. Thank you

@mauron85 mauron85 closed this Apr 12, 2018
mauron85 added a commit to mauron85/react-native-background-geolocation that referenced this pull request Apr 12, 2018
mauron85 added a commit to mauron85/cordova-plugin-background-geolocation that referenced this pull request Apr 20, 2018
Improved logging capabilities:
- option to get logs by offset and filter by log level
- log uncaught exceptions
- iOS use Android log format

Improved location syncing on Android:
- reuse thread for location posting/syncing
- post and sync queue
- remove delay and sync immediately when conditions are met
- consider HTTP 201 response code as succesful posta

Bugs:
Android fix some nullpointer exceptions

Origin PR:
mauron85/background-geolocation-android#2
Submitted-By: @chuece
mauron85 added a commit to mauron85/cordova-plugin-background-geolocation that referenced this pull request Apr 20, 2018
Improved logging capabilities:
- option to get logs by offset and filter by log level
- log uncaught exceptions
- iOS use Android log format

Improved location syncing on Android:
- reuse thread for location posting/syncing
- post and sync queue
- remove delay and sync immediately when conditions are met
- consider HTTP 201 response code as succesful post

Bugs:
Android fix some nullpointer exceptions

Origin PR:
mauron85/background-geolocation-android#2
Submitted-By: @chuece
mauron85 added a commit to mauron85/cordova-plugin-background-geolocation that referenced this pull request May 2, 2018
Android:
- add guards to prevent some race conditions
- facade throws PluginException
- remove sync delay when conditions are met
- consider HTTP 201 response code as succesful post
- obey sync settings
- PluginError extends Exception
- config null handling
- common error format

Bugs:
- Android fix some nullpointer exceptions

Origin PR:
mauron85/background-geolocation-android#2
Submitted-By: @chuece

iOS:
- iOS use Android log format

Common:
- option to get logs by offset and filter by log level
- log uncaught exceptions
- method forceSync
mauron85 added a commit to mauron85/cordova-plugin-background-geolocation that referenced this pull request May 2, 2018
Android:
- add guards to prevent some race conditions
- facade throws PluginException
- remove sync delay when conditions are met
- consider HTTP 201 response code as succesful post
- obey sync settings
- PluginError extends Exception
- config null handling
- common error format
- Android fix some nullpointer exceptions
    Origin PR:
      mauron85/background-geolocation-android#2
    Submitted-By: @chuece

iOS:
- use Android log format
- adjust to changes in common module

Common:
- option to get logs by offset and filter by log level
- log uncaught exceptions
- method forceSync
jsimonassi pushed a commit to jsimonassi/background-geolocation-android that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants