-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding event to know how many items were matched #98
base: main
Are you sure you want to change the base?
adding event to know how many items were matched #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks!!
Would you mind looking at adding a test or two to capture that we're now returning the correct number of matched items?
@@ -33,6 +33,7 @@ | |||
@input="handleInput($event.target.value)" | |||
@keydown.esc="handleEsc($event.target.value)" | |||
@keyup="$emit('keyup', $event)" | |||
@matched-items="$emit('matched-items', $event)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's call this matched-items-count
?
@matched-items="$emit('matched-items', $event)" | |
@matched-items-count="$emit('matched-items', $event)" |
I'm still interested in this PR. Any chance you're interested in adding a few tests? |
Hi @mattzollinhofer, |
Hmm, I’m not sure. When I run |
Hi, may I know how can I get the matched items so I can display "No data found"? |
@hd-diegocortez: I just want to check in again. If you run Here's the steps to getting the project to work locally:
Then to run tests it should just be I'm not sure if it matters or not, but I'm on node v15.3.0 and vue 4.2.2 |
Solving issue here
#88