Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use picocolors and tinyglobby and biome check fix #375

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: use picocolors and tinyglobby and biome check fix #375

merged 3 commits into from
Jan 28, 2025

Conversation

wChenonly
Copy link
Contributor

  1. use picocolors and tinyglobby lighter weight for better performance
  2. add biome check --fix
  3. import of bun:test

@mattzcarey
Copy link
Owner

nice pr. I will review it shortly :)

mattzcarey
mattzcarey reviewed Jan 20, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
mattzcarey
mattzcarey requested changes Jan 20, 2025
View reviewed changes
Copy link
Owner

@mattzcarey mattzcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the new script please. if you want a fix option please use name check:fix

src/common/remote/github/extractPullRequestIdentifier.test.ts Show resolved Hide resolved
@wChenonly
Copy link
Contributor Author

remove the new script please. if you want a fix option please use name check:fix

resolve

@mattzcarey mattzcarey merged commit 760e830 into mattzcarey:main Jan 28, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Open
@wChenonly wChenonly deleted the use branch January 28, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattzcarey mattzcarey mattzcarey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wChenonly @mattzcarey