Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] - Add taxonomies for Tags, Series and Categories #306

Closed
chrisreddington opened this issue Nov 30, 2020 · 6 comments · Fixed by #307
Closed

[ENHANCEMENT] - Add taxonomies for Tags, Series and Categories #306

chrisreddington opened this issue Nov 30, 2020 · 6 comments · Fixed by #307

Comments

@chrisreddington
Copy link
Contributor

I've been working on enhancing my own deployment of the site to leverage Hugo Taxonomies for Tags, Series and Categories.

You can find a live version at https://www.cloudwithchris.com/

I merged this into my master branch at CloudWithChris/cloudwithchris.com@68191a6

Would you approve of these changes to be merged into the castanet theme, and if so, any additional requirements? I'm mainly thinking around configuration of whether folks would want tags/categories/etc. on their own pages, so making sure there is some flexibility (which I hadn't yet considered in my deployment).

Thanks!

@mattstratton
Copy link
Owner

Let me take a look! I think the biggest thing is to ensure that it doesn't break if someone doesn't use tags/series/categories...I'll dig into that.

the biggest requirement I could see beyond that is making sure that we update REFERENCE.md with documentation on how to use them, etc.

@mattstratton
Copy link
Owner

I found a bug in your partials/row.html where it looks like it's selecting only upcoming; that would need to be fixed.

also, the taxonomy pages are not filtering based on upcoming, which I think would need to be fixed?

@mattstratton
Copy link
Owner

Let's put it this way - can you put together a PR with these changes? It might be easier for me to review that way, since it would only include the changes for the theme.

also, you'll want to add each type of taxonomy to some of the episodes in the exampleSite (as well as the config for exampleSite so we can see how it works!

@chrisreddington
Copy link
Contributor Author

Absolutely, will get to that later today/tomorrow. Just wanted to first figure out if this was useful to bring the changes back into the repo before putting the effort there :)

@mattstratton
Copy link
Owner

Definitely useful! I feel like there might even be an existing issue on this...let me find it!

@mattstratton
Copy link
Owner

mattstratton commented Nov 30, 2020

I suspect this would handle #245

(no need to remove this issue; this is more to point out that someone else wanted it, and also a note to myself to make sure we add closing keywords to the PR for both #306 and #245)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants