Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting typos in the remote origin URL text field. #2

Closed
mattrltrent opened this issue Jun 6, 2024 · 3 comments
Closed

Correcting typos in the remote origin URL text field. #2

mattrltrent opened this issue Jun 6, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mattrltrent
Copy link
Owner

Very often people enter a wrong version of this field:

Screenshot 2024-06-05 at 6 12 11 PM

Like, very often (>50% of the time) they forget the .git extension or don't prefix it with https://. Some regex could be added to auto fix this issue.

@mattrltrent mattrltrent added the good first issue Good for newcomers label Jun 6, 2024
RamanaRaj7 added a commit to RamanaRaj7/github_painter that referenced this issue Jun 6, 2024
@RamanaRaj7
Copy link
Contributor

isn't this solved?

@mattrltrent
Copy link
Owner Author

Mostly, yes. However, sometimes users enter repo URLs in the form: github.com/username/repo and forget the https:// prefix.

Ideally, the code would do a quick check using Regex to see if the URL entered already has https:// before it, and if not, add it.

Moreover, instead of indiscriminately adding .git to the end of every URL, the code would again check with Regex to see if the user entered a .git postfix or not and then choose to add .git or not at the end accordingly.

@RamanaRaj7
Copy link
Contributor

ooh ok got it.

RamanaRaj7 added a commit to RamanaRaj7/github_painter that referenced this issue Jun 7, 2024
fix for issue mattrltrent#2 and Partial fix with errors for issue mattrltrent#4
RamanaRaj7 added a commit to RamanaRaj7/github_painter that referenced this issue Jun 7, 2024
fix for issue mattrltrent#2
and added js alert when the entered link is partial like it when it includes only user name or only the repo name
mattrltrent added a commit that referenced this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants