Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Start attempt to use altair for plotting #33

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Conversation

mattpitkin
Copy link
Owner

Start trying out using Altair to make plots if requested. Refs #3. Supercedes #31 as I've changed the branch name to be more appropriate.

@mattpitkin mattpitkin self-assigned this Aug 9, 2018
@pep8speaks
Copy link

pep8speaks commented Aug 9, 2018

Hello @mattpitkin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2687:101: E501 line too long (133 > 100 characters)
Line 2713:1: W293 blank line contains whitespace
Line 2834:101: E501 line too long (113 > 100 characters)
Line 2837:101: E501 line too long (108 > 100 characters)
Line 2839:101: E501 line too long (108 > 100 characters)
Line 2840:101: E501 line too long (160 > 100 characters)
Line 2842:101: E501 line too long (110 > 100 characters)
Line 2843:101: E501 line too long (110 > 100 characters)
Line 2846:1: W293 blank line contains whitespace
Line 2939:25: W291 trailing whitespace

Comment last updated at 2020-01-13 23:21:08 UTC

@mattpitkin
Copy link
Owner Author

Another thing to add in this the ability to use a set a 'symlog' scale. This is currently not implemented in Atlair (vega/altair#1077) due to not being implemented in a chain of dependencies going back through Vega-Lite, Vega and d3. When/if these are resolved I can add this option.

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #33 into master will decrease coverage by 0.82%.
The diff coverage is 31.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   70.54%   69.71%   -0.83%     
==========================================
  Files           4        4              
  Lines        2241     2282      +41     
  Branches      424      442      +18     
==========================================
+ Hits         1581     1591      +10     
- Misses        478      500      +22     
- Partials      182      191       +9
Impacted Files Coverage Δ
psrqpy/search.py 71.97% <31.74%> (-1.22%) ⬇️
psrqpy/utils.py 57.65% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9448180...9911925. Read the comment docs.

@mattpitkin
Copy link
Owner Author

symlog is now supported by altair, so I can add this option.

@mattpitkin
Copy link
Owner Author

To output html that contains the chart, and can also still be used interactively, see here.

@mattpitkin mattpitkin closed this Nov 28, 2019
@mattpitkin mattpitkin reopened this Nov 28, 2019
@mattpitkin
Copy link
Owner Author

Also, maybe look at using rich displays options for "automatic" generation using altair if using a Jupyter notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants