-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Start attempt to use altair for plotting #33
base: main
Are you sure you want to change the base?
Conversation
Hello @mattpitkin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-01-13 23:21:08 UTC |
Another thing to add in this the ability to use a set a 'symlog' scale. This is currently not implemented in Atlair (vega/altair#1077) due to not being implemented in a chain of dependencies going back through Vega-Lite, Vega and d3. When/if these are resolved I can add this option. |
…to pulsar parameters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 70.54% 69.71% -0.83%
==========================================
Files 4 4
Lines 2241 2282 +41
Branches 424 442 +18
==========================================
+ Hits 1581 1591 +10
- Misses 478 500 +22
- Partials 182 191 +9
Continue to review full report at Codecov.
|
symlog is now supported by altair, so I can add this option. |
To output html that contains the chart, and can also still be used interactively, see here. |
Also, maybe look at using rich displays options for "automatic" generation using altair if using a Jupyter notebook. |
Start trying out using Altair to make plots if requested. Refs #3. Supercedes #31 as I've changed the branch name to be more appropriate.