Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegisterAggregator requires "trace" build tag? #433

Closed
ghost opened this issue Jul 6, 2017 · 2 comments
Closed

RegisterAggregator requires "trace" build tag? #433

ghost opened this issue Jul 6, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 6, 2017

There may be a very good reason for this, for example gating the use of reflect behind a tag, but I was confused to discover that RegisterAggregator was not a default feature when I found it in one of the examples.

The line is here, and I can only get the custom_func example to build with go build -tags trace.

That's fine, if documented more clearly. But, does including -tags trace install performance-degrading hooks elsewhere? Is there a disadvantage to enabling the trace flag?

Thanks!
@mattn
Copy link
Owner

mattn commented Jul 7, 2017

does including -tags trace install performance-degrading hooks elsewhere? Is there a disadvantage to enabling the trace flag?

Yes. If you are okay to install go-sqlite3 system-global, please do go -tags trace install on directory of go-sqlite3.

@ghost
Copy link
Author

ghost commented Jul 11, 2017

Is it possible to separate the two? The performance-costly hooks and the RegisterAggregator function?

gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue May 26, 2018
@gjrtimmer
Update documentation
4a90a03 
Compile Section Closes mattn#175
Compile Section Closes mattn#201
Compile Section Closes mattn#206
Compile Section Closes mattn#404
Compile Section Closes mattn#217
Compile Section Closes mattn#224
Compile Section Closes mattn#234
Compile Section Closes mattn#242
Feature table Closes mattn#255
Description Section Closes mattn#232
Golang:1.6 not supported Closes mattn#272
Golang:1.5 not supported + compilation section Closes mattn#283
usleep Implemented Closes mattn#285
FAQ Section Closes mattn#289
Compile Section closes mattn#295
FAQ Section Closes mattn#305
PR339 Closes mattn#318 mattn#321
Compilation Section Closes mattn#341
PR407 Closes mattn#364
Feature `sqlite_vtable` Closes mattn#393
Compile Section Closes mattn#416
sqlite_trace feature Closes mattn#433
Compilation Section Closes mattn#435
Compilation Section Closes mattn#443
Golang:1.6 Not Supported Closes mattn#445
Compilation Section Closes mattn#451
Compilation Section Closes mattn#467
Compilation Section Closes mattn#491
Compilation Section Closes mattn#495
Compilation Section Closes mattn#505
Compilation Section Closes mattn#557
Compilation Section Closes mattn#560
@mattn mattn closed this as completed in c9394b1 May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattn