fix: compare URI case insensitive #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerman
commented
Jul 20, 2024
| @@ -556,7 +556,8 @@ func (h *langHandler) lint(ctx context.Context, uri DocumentURI, eventType event | |||
| continue | |||
| } | |||
| } else { | |||
| if diagURI != uri && !config.LintWorkspace { | |||
| diagFname, _ := fromURI(diagURI) | |||
There was a problem hiding this comment.
It is safe to ignore error here because diagURI is either uri (which already was checked for fromURI() error) or result of toURI()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim sends filenames to LSP as URI using lower case %-encoding.
For some tools (when
entry.Filenameis not empty) current implementation converts filename to URI (using upper case %-encoding) and then compare two URI in case-sensitive way.This result in hard to notice issue: if filename contains non-ASCII symbols then some linters work (e.g.
djlint) while others (e.g.markdownlint) doesn't work. And "doesn't work" here means Neovim gets no diagnostics even if there are some errors.