Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antidote tries to clone local package declarations from github #98

Closed
soupersauce opened this issue Feb 1, 2023 · 5 comments · Fixed by #99
Closed

antidote tries to clone local package declarations from github #98

soupersauce opened this issue Feb 1, 2023 · 5 comments · Fixed by #99

Comments

@soupersauce
Copy link

soupersauce commented Feb 1, 2023

 antidote cloning ~/.fzf/shell/...
# antidote cloning ~/.config/zsh/zshrc.d/...
remote: Please upgrade your git client.
remote: GitHub.com no longer supports git over dumb-http: https://github.com/blog/809-git-dumb-http-transport-to-be-turned-off-in-90-days
fatal: unable to access 'https://github.com/~/.fzf/shell/': The requested URL returned error: 403
remote: Please upgrade your git client.
remote: GitHub.com no longer supports git over dumb-http: https://github.com/blog/809-git-dumb-http-transport-to-be-turned-off-in-90-days
fatal: unable to access 'https://github.com/~/.config/zsh/zshrc.d/': The requested URL returned error: 403
remote: Please upgrade your git client.
remote: GitHub.com no longer supports git over dumb-http: https://github.com/blog/809-git-dumb-http-transport-to-be-turned-off-in-90-days
fatal: unable to access 'https://github.com/~/.fzf/shell/': The requested URL returned error: 403
antidote: error: bundle path not found '/home/.../.cache/antidote/.fzf/shell'
echo $ZSH_VERSION
5.8.1
@mattmc3 mattmc3 mentioned this issue Feb 1, 2023
@mattmc3
Copy link
Owner

mattmc3 commented Feb 1, 2023

This is a timely bug report. Thanks for submitting it. I was just working on the 1.7.3 release and had already fixed this issue. I was going to put more features in before cutting a release, but since this is affecting someone right now, I'll push those out to 1.7.4 and publish. This should work now if you run antidote update.

@soupersauce
Copy link
Author

Much appreciated.

@razvanazamfirei
Copy link

This is a follow-up on the fix. The plugins get attached, but it still throws up errors.

 # Clear local plugins from zsh_plugins.txt
 ~ antidote load
 ~ exec zsh
 # Add local plugins back
 ~ antidote load
# antidote cloning $ZDOTDIR/plugins/brew...
# antidote cloning $ZDOTDIR/plugins/python...
# antidote cloning $ZDOTDIR/plugins/utility...
# antidote cloning $ZDOTDIR/plugins/xdg-basedir...
remote: Not Found
fatal: repository 'https://github.com/$ZDOTDIR/plugins/utility/' not found
remote: Not Found
fatal: repository 'https://github.com/$ZDOTDIR/plugins/brew/' not found
remote: Not Found
fatal: repository 'https://github.com/$ZDOTDIR/plugins/xdg-basedir/' not found
remote: Not Found
fatal: repository 'https://github.com/$ZDOTDIR/plugins/python/' not found
# antidote cloning $ZDOTDIR/plugins/brew...
remote: Not Found
fatal: repository 'https://github.com/$ZDOTDIR/plugins/brew/' not found
antidote: error: bundle path not found '/Users/johnqpublic/.config/zsh/.antidote/.plugins/plugins/brew'.
 ~ exec zsh
 ~ echo $ZSH_VERSION 
   5.8.1
 ~ antidote -v
   antidote version 1.7.3

Despite the errors, the plugins still work. Not a big issue, since antidote still works, but a bit confusing.

@mattmc3 mattmc3 reopened this Feb 1, 2023
@mattmc3
Copy link
Owner

mattmc3 commented Feb 1, 2023

Thank you for reporting back, and for your patience. Right now, 1.7.3 only supports paths beginning with / or ~. If you replace $ZDOTDIR with ~/path/to/zdotdir does it work properly? I have been using envsubst for my config to handle vars like $ZDOTDIR, but honestly, antidote should just support variables natively. I’ll see if I can get that feature out soon.

@razvanazamfirei
Copy link

My bad, I missed responding to this. It worked with /Users/username/path/to/zdotdir. I did not try it with ~/path/to/zdotdir, but I assume it would've worked fine. I tested 1.7.4 and using the $ZDOTDIR var works great. Thank you again for your work on this as well as your responsiveness.

mattmc3 added a commit that referenced this issue Feb 20, 2023
- don't try to clone missing local plugins
- missing local plugins should still output the expected load script
- favor not failing during bundling, but when sourcing the result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants