-
-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing SASS entry point #1595
Conversation
This change would allow importing the sass files in Angular projects in the following fashion: `@import "~angular-calendar/scss/angular-calendar";` That is beneficial for plugins trying to find the critical path CSS, and allows to avoid having to hardcode a relative path to the node_module, simplifying adoption in monorepos with multiple projects.
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the fix!!
Released as |
Yup thanks, works perfectly! |
Hello @santam85 & @mattlewis92 |
I think it's because angular dropped support for the leading |
it works, Thank you for the quick response |
This change would allow importing the sass files in Angular projects in the following fashion:
@import "~angular-calendar/scss/angular-calendar";
That is beneficial for plugins trying to find the critical path CSS, and allows to avoid having to hardcode a relative path to the
node_module
, simplifying adoption in monorepos with multiple projects.Fixes #1596 and errors like:
Alternatively, this can be extended to all scss files by adding instead:
EDIT
After some research and testing, I updated the PR to use the alternative approach shown above, looks like it's the one that has the best compatibility.