Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeViewRender enhancements #418

Closed
2 tasks done
mattlewis92 opened this issue Dec 23, 2017 · 0 comments
Closed
2 tasks done

beforeViewRender enhancements #418

mattlewis92 opened this issue Dec 23, 2017 · 0 comments

Comments

@mattlewis92
Copy link
Owner

mattlewis92 commented Dec 23, 2017 •
edited
Loading

  • The week and day view beforeViewRender callbacks are currently only called when the header / hour grid is rendered which is inconsistent with the month view.
  • Expose the view start and end for each callback so that implementing No events founds label #411 becomes trivial
@mattlewis92 mattlewis92 changed the title beforeViewRender should be called before any part of the view renders beforeViewRender enhancements Dec 23, 2017
@mattlewis92 mattlewis92 mentioned this issue Dec 23, 2017
Closed
mattlewis92 pushed a commit that referenced this issue Jan 1, 2018
feat(week-view): expose the view period on beforeViewRender
cb73eff 
BREAKING CHANGE: for people extending the root week view component, eventRows is now named view.eventRows

Closes #418
mattlewis92 pushed a commit that referenced this issue Jan 1, 2018
feat(day-view): expose the period on the beforeViewRender output
24739ce 
BREAKING CHANGE: the event signature of the beforeViewRender output has changed from $event.body to $event.body.hourGrid

Closes #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattlewis92