Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for explicit FullHD and HD4k setting #28

Merged

Conversation

vlussenburg
Copy link
Contributor

Explain what you're changing and why here.

Adding Full HD and HD4k options, see https://developer.apple.com/documentation/avfoundation/avcapturesession/preset

Test report:

vincent@vmbp videosnap % /Users/vincent/Documents/videosnap/build/pkgroot/usr/local/bin/videosnap -d "Insta360 Link" -p "3840x2160" -v 
(discovering devices)
(opting in for connected DAL devices, may delay or fail when connecting to DAL assistant port)
(opting in for screen capture devices)
(waiting 2 secs for devices to connect to DAL assistant)
(no filename specified, using default: movie-2023-12-02-203319.mov)
(options before recording)
  delay:    0.50s
  duration: 0.00s
  file:     movie-2023-12-02-203319.mov
  video:    3840x2160
  audio:    HQ AAC
  device:   Insta360 Link
            UVC Camera VendorID_11802 ProductID_19457 - Insta360
(initializing capture session)
(adding video device)
(adding audio device)
(adding movie file output)
(set capture framerate to 30 fps)
(setting encoding preset)
(starting capture session)
(delaying for 0.50 seconds)
(delay period ended)
(starting capture to file at 'movie-2023-12-02-203319.mov')
Started capture (ctrl+c to stop, ctrl+z to pause) ...
^C
(caught signal: [2])
(stopping recording)
(finished writing to movie file)
(stopping capture session)

Captured 7.53 seconds of video to 'movie-2023-12-02-203319.mov'

📝 Checklist

Please check this list and leave it intact for the reviewer. Thanks! ❤️

  • Commit messages provide context (why not just what, some tips here).
  • If relevant, mention GitHub issue number above and include in a commit message.
  • Latest code from master merged.
  • New behaviour has test coverage.
  • Avoid duplicating code.
  • No commented out code.
  • Avoid comments for your code, write code that explains itself.
  • Changes are simple, useful, clear and brief.

@vlussenburg vlussenburg changed the title Update Constants.m Add support for explicit FullHD and HD4k setting Dec 3, 2023
@matthutchinson matthutchinson merged commit 124baf1 into matthutchinson:main Dec 3, 2023
@matthutchinson
Copy link
Owner

Thanks @vlussenburg I'll see if I can cut a release soon, its been a while since I built (and notarised) so might take some wrangling with certs

@matthutchinson
Copy link
Owner

Released v0.0.9 with this just now 🏁

@vlussenburg vlussenburg deleted the vlussenburg-patch-1 branch December 31, 2023 21:37
@vlussenburg
Copy link
Contributor Author

Yay! Thanks @matthutchinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants