Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ActiveSupport::TestCase.test_order to avoid warning #174

Merged
merged 1 commit into from
May 26, 2015
Merged

Set ActiveSupport::TestCase.test_order to avoid warning #174

merged 1 commit into from
May 26, 2015

Conversation

vandrijevik
Copy link
Contributor

Running the tests shows the following warning:

DEPRECATION WARNING: You did not specify a value for the configuration option `active_support.test_order`. In Rails 5, the default value of this option will change from `:sorted` to `:random`.
To disable this warning and keep the current behavior, you can add the following line to your `config/environments/test.rb`:

  Rails.application.configure do
    config.active_support.test_order = :sorted
  end

Alternatively, you can opt into the future behavior by setting this option to `:random`. (called from test_order at /Users/vladimir/code/foreigner/.bundle/gems/gems/activesupport-4.2.1/lib/active_support/test_case.rb:42)

this PR fixes that by setting the test order to :random (effectively following the second advice in the warning, and opting into the future behavior).

matthuhiggins added a commit that referenced this pull request May 26, 2015
…-warning

Set ActiveSupport::TestCase.test_order to avoid warning
@matthuhiggins matthuhiggins merged commit 7c5261a into matthuhiggins:master May 26, 2015
@matthuhiggins
Copy link
Owner

Thanks! I hadn't run the tests for quite a while.

@vandrijevik vandrijevik deleted the fix-activesupport-test-order-warning branch May 27, 2015 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants