Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning from ActiveSupport for Kernel#capture #173

Merged
merged 2 commits into from
May 27, 2015
Merged

Fix deprecation warning from ActiveSupport for Kernel#capture #173

merged 2 commits into from
May 27, 2015

Conversation

vandrijevik
Copy link
Contributor

Fixes the ActiveSupport deprecation warning:

DEPRECATION WARNING: `#capture(stream)` is deprecated and will be removed in the next release. (called from block in <class:MysqlAdapterTest> at /Users/vladimir/code/foreigner/test/foreigner/connection_adapters/mysql_adapter_test.rb:6)

by moving away from capture and using Foreigner::UnitTest#with_stdout. In the process, moves Foreigner::AdapterTest to be a subclass of Foreigner::UnitTest so this method is available.

Note: If this PR is accepted before #172, I will refactor that code to just use the Foreigner::UnitTest#with_stdout method instead of defining it on AdapterTest.

@matthuhiggins
Copy link
Owner

This has conflicts with the other PR. If you fix these I will merge.

@vandrijevik
Copy link
Contributor Author

@matthuhiggins Thanks for the quick review and merge of the other two! I fixed the conflict, so this should be good to go.

matthuhiggins added a commit that referenced this pull request May 27, 2015
…capture

Fix deprecation warning from ActiveSupport for Kernel#capture
@matthuhiggins matthuhiggins merged commit 7cec7db into matthuhiggins:master May 27, 2015
@vandrijevik vandrijevik deleted the fix-deprecation-warning-for-capture branch May 27, 2015 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants