options: "deferrable" missing in schema.rb

[mkllnk]

Hello,

I use add_foreign_key to add deferrable constraints to a PostgreSQL database.

add_foreign_key "spree_orders", "carts", name: "spree_orders_cart_id_fk", options: "deferrable"

That works fine in the migration and all commands are added to schema.rb --- except the last part , options: "deferrable". There is just:

add_foreign_key "spree_orders", "carts", name: "spree_orders_cart_id_fk"

Am I doing something wrong? Is it out of scope or a bug?

[subakva]

It looks as if this has been a problem for a while: #105 (comment)

For what it's worth, you can work around this by dumping your schema in SQL format.

In application.rb:

  config.active_record.schema_format = :sql

[jenseng]

@matthuhiggins although you don't plan to support database-specific features (understandable, and i agree), what's your take on inferring/preserving the :options in schema dumper? if you're ok with that, i'd be happy to throw together a PR for it.

seems like that would solve this particular issue, and greatly reduce db-specific feature requests in the future :)

[matthuhiggins]

Hmm, I could go for that. Do you think you could parse out the options in a sufficiently generic way?

[jenseng]

yeah it looks pretty trivial...

for mysql it's a noop because it doesn't support any options after the ON <event> <action>

for postgresql, we can just take whatever appears after the ON <event> <action> ... that would be the stuff like DEFERRABLE / NOT VALID that people are expecting

i don't think we need to do anything beyond that, because things like MATCH matchtype and actions like SET DEFAULT:

1. appear in different places in the statement,
2. are pretty db-specific, and
3. can't even be specified by an add_foreign_key call so it doesn't make sense to preserve them

[matthuhiggins]

Sounds like a plan