Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matthias!
I came across your ORM after reading about it in Advanced Web Application Architecture (great book btw!). I decided to try it out in a sample project, and so far it's working really well, thank you! 👍
The only issue that I had with it is that phpstorm & phpstan complained about the incorrect type being returned by
AggregateRepository::getById()
when using it in my repository implementation.This PR fixes that, and while I was at it, I added some more type annotations so that it plays nicer with both phpstorm and phpstan (and potentially psalm?).
Let me know what you think :)