Skip to content

Commit

Permalink
Rollup merge of rust-lang#125719 - Zalathar:run-coverage, r=jieyouxu
Browse files Browse the repository at this point in the history
Extract coverage-specific code out of `compiletest::runtest`

I had been vaguely intending to do this for a while, but seeing rust-lang#89475 on the compiletest dashboard inspired me to actually go and do it.

This moves a few hundred lines of coverage-specific code out of the main module, making navigation a bit easier. There is still a small amount of coverage-specific logic in broader functions in that module, since it can't easily be moved.

This is just cut-and-paste plus fixing visibility and imports, so no functional changes.

I also removed the unit test for anonymizing line numbers in MC/DC reports, as foreshadowed by the comment I wrote when adding it. That functionality is now adequately exercised by the actual snapshot tests for MC/DC coverage.

(Removing the test now avoids the need to move it, or to make the function it calls visible.)
  • Loading branch information
matthiaskrgr authored May 29, 2024
2 parents e4ec56a + 268b9a7 commit 6ef3dd0
Show file tree
Hide file tree
Showing 3 changed files with 372 additions and 426 deletions.
Loading

0 comments on commit 6ef3dd0

Please sign in to comment.