Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

No support for "non-minecraft" CurseForge sites #12

Open
dries007 opened this issue Jan 28, 2018 · 8 comments
Open

No support for "non-minecraft" CurseForge sites #12

dries007 opened this issue Jan 28, 2018 · 8 comments

Comments

@dries007
Copy link

Hi, I'm using this plugin in a multi-version spanning Minecraft mod, that also has a Bukkit version.

The bukkit version doesn't upload correctly because the API's base URL is dev.bukkit.org instead of minecraft.curseforge.com.
If this was made settable, it would allow not only bukkit plugins, but also all other sites, such as Terraria, KSP and others.

Please consider adding support,
Thanks in advance,
Dries

@dshadowwolf
Copy link
Contributor

@matthewprenger hrm... currently the domain is hard-coded as a final - I've been looking at this and pondering how to fix this, would you prefer a DSL setting with it defaulting to the current or is there another method that you'd like to see implemented ?

@matthewprenger
Copy link
Owner

@dshadowwolf In my mind this would be a field in the project closure where the default is the Minecraft url. Something like:

project {
    apiUrl = 'https://dev.bukkit.org'
    id = '1234'
}

The CurseVersions class would also have to be refactored to handle multiple games.

@dries007
Copy link
Author

@matthewprenger This was what I was hoping for 👍

@dshadowwolf
Copy link
Contributor

@matthewprenger that is pretty close to what I was thinking of - though I'd had a thought of maybe having some predefined values somewhere for convenience.... I'll get on this in a few - Windows just had to update on me.

ErdbeerbaerLP added a commit to ErdbeerbaerLP/DiscordIntegration-Spigot that referenced this issue May 13, 2021
@Cloudate9
Copy link

Over 3 years later, is the conclusion that this is not going to be added? Support for Bukkit or other games would be great, if possible...

@dshadowwolf
Copy link
Contributor

I've been running on the edge of burnout for about 30 months now - usually falling just on the "burned out" side of things - so I've really not been able to find any motivation for any hobbies involving coding. Sorry, if anything is to come of this, it won't be a PR from me.

@Cloudate9
Copy link

Cloudate9 commented Oct 11, 2021

I've been running on the edge of burnout for about 30 months now - usually falling just on the "burned out" side of things - so I've really not been able to find any motivation for any hobbies involving coding. Sorry, if anything is to come of this, it won't be a PR from me.

Dw, take your rest. Maybe I'll create a pr if I ever find time.

@jriwanek
Copy link
Contributor

See PR#36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants