Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Swift 4.2 #199

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

benlachman
Copy link

Simple conversion from 4.0 to 4.2 along with project file updates and the removal of unused pod config files referenced from Xcode.

@tc
Copy link

tc commented Dec 16, 2018

@benlachman looks like the CI tests are failing:

❌  “Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

@DmitryPR
Copy link

What is the reason Travis is failing? Can we get this fixed?

@gcharita
Copy link

You probably need to change osx_image to xcode10.1 in .travis.yml file, to see if this PR actually passes the tests.

@DmitryPR DmitryPR mentioned this pull request Jan 17, 2019
@grifas
Copy link

grifas commented Feb 4, 2019

Any news ?

@DmitryPR
Copy link

DmitryPR commented Feb 4, 2019

Created a separate PR with this fix and travis fix not sure who can review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants