Adds "upload to s3" capabilities if configured #138
Conversation
|
Based on #120 |
|
The travis build seems to only be failing for RSpec 2.14 and RSpec 2.99 Is this actually an issue with master? |
|
@chendrix, you may be right, it might be an issue with master, I am looking into it now. Once I get that resolved, if you wouldn't mind rebasing that would be appreciated so that I can see if this passes. I'll give you an update soon. |
|
It seems this is almost certainly an RSpec / other dependency issue. I have reverted to a passing build https://travis-ci.org/mattheworiordan/capybara-screenshot/builds/68825014, and run the tests and they fail. I will do my best to track down the cause of the issue. |
|
Sure, would gladly rebase off new master once it gets fixed. |
- Introduces an S3Saver that's a transparent facade over a Saver - Refactors all saver instantiation behind saver "factory method" which dynamically chooses whether to give you an S3Saver depending on if you have configured s3 upload - Defaults to 'us-east-1' region if not specified
|
@mattheworiordan simple rebase. If travis passes, should be clean to merge. |
|
So travis is failing again, but master's tests are also failing. |
|
Some great work @chendrix, thank you. Yes, you are right, the CI builds have gone mental, I will need to address that again soon. |
dynamically chooses whether to give you an S3Saver depending on if you
have configured s3 upload